You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding numeric release notes for an upcoming release forced a public version-selector entry before its documentation existed. Core 1.4.0 consequently appeared in the live dropdown with a destination that returned 404.
Remove the selector requirement and its obsolete tests from the staged release-note hook, keeping bindings/metapackage note pairing intact. Remove the premature Core 1.4.0 selector entry while retaining its release notes. The always-run hook now exercises this real case in both native pre-commit CI jobs.
Correct the Core and bindings release guides, all five package documentation READMEs, and CI documentation: local builds need no selector entry; add release entries on main after the component is published and its versioned documentation is deployed. Main deployments own the shared selectors; a missing entry can be repaired there without changing a release tag.
Inspected cuda_bindings_12/docs/build_docs.sh and cuda_bindings_13/docs/build_docs.sh: CUDA 12 consumes CUDA 13's canonical selector, so no root-specific build changes are needed. No SYNCED blocks are touched.
Validation:
75 existing staged-note, tag-CI, and publication-preflight tests pass on Python 3.11.
pre-commit run --all-files passes, including the staged-note hook with Core 1.4.0's selector entry removed.
Public CI passed before the README-only review follow-up: CI-tool tests, API checks, all seven Linux builds, documentation and rendered-link checks, and preview deployment.
The README-only review follow-up passes local pre-commit run --all-files, including authored-link checks. Full CUDA CI is intentionally deferred for that follow-up; automatic direct PR checks may run.
The [doc-only] title directive retains CI-tool tests, pre-commit checks, Linux builds, and documentation validation while skipping package runtime tests. These changes affect release-note tooling, selector metadata, and release guidance.
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
Documentation
Clarified that shared version switchers are updated on main only after versioned documentation is published and deployed. Release deployments do not update shared selectors or latest pages.
Release notes may be merged before publication without a switcher entry. Missing entries should be corrected on main without changing the release tag.
Updated documentation build guidance: local builds do not require a version-selector entry, and older versioned pages should remain available.
Updated release-note check guidance to focus on matching bindings and Python release notes.
Chores
Removed CUDA Core 1.4.0 from the version list.
Release guidance separates release-note pairing from documentation selector updates. The staged checker validates paired bindings and metapackage release notes. Selector entries are added on main after versioned documentation is published and deployed.
Release instructions and package documentation defer selector updates until versioned documentation is published and deployed. They state that main controls shared selectors and that missing entries should be fixed on main without changing the release tag. The CUDA Core version list no longer includes 1.4.0.
The staged checker now checks only paired bindings and metapackage release notes. Its hook label and documentation no longer describe selector validation. The selector-validation test module was removed.
Possibly related PRs
NVIDIA/cuda-python#3498: Adds selector checks to the staged hook, which this change removes, and changes selector ownership.
Suggested reviewers:leofang
Change: Other
Merge Risk: Minimal · up to 34dba
This change moves documentation selector updates to after publication and removes the premature Core 1.4.0 entry. Release-note pairing checks remain in place, and no runtime behavior changes. It is ready to merge.
Architecture concerns
No architecture-level concerns identified.
Review details
Systems and components
observed — ci (service) was modified; 3 changed files map to changed impact.
observed — cuda_core (service) was modified; 2 changed files map to changed impact.
observed — cuda_bindings_12 (service) was modified; 1 changed file maps to changed impact.
observed — cuda_bindings_13 (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
observed — Modified behavior in ci/tools/check_staged_release_notes.py: The module description now covers staged bindings and metapackage release-note pairs. The release-note pattern no longer matches cuda_core or cuda_pathfinder paths, and the json import and selector URL configuration were removed.
observed — Modified behavior in ci/tools/check_staged_release_notes.py: The Git index listing no longer includes cuda_core or cuda_pathfinder release-note paths.
observed — Modified behavior in ci/tools/check_staged_release_notes.py: Release notes that match the narrowed path pattern are now included according to _requires_pairing; the former package-specific thresholds for cuda_core and cuda_pathfinder were removed.
observed — Modified behavior in ci/tools/check_staged_release_notes.py: main now checks and reports only missing release-note pairs. It no longer combines selector errors with pairing errors, and its failure guidance now names matching cuda-bindings and cuda-python release notes.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between 9302bf8 and 34dbaaa.
Files selected for processing: 5
cuda_bindings_12/docs/README.md
cuda_bindings_13/docs/README.md
cuda_core/docs/README.md
cuda_pathfinder/docs/README.md
cuda_python/docs/README.md
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
suggestion: Remove the test for an explicit hook failure.
This test checks that the hook accepts release notes without selectors. An incorrect rejection already produces an immediate CI failure through the always-run hook. It does not produce a silent wrong outcome.
As per coding guidelines, “Keep a test only when wrong behavior would be silent.”
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
Nit: step 2 of the package docs READMEs still says "Ensure the version is included in nv-versions.json", which reads as if the entry should be added before building/publishing:
cuda_core/docs/README.md (line 4)
cuda_pathfinder/docs/README.md (line 4)
cuda_bindings_13/docs/README.md (line 4)
cuda_bindings_12/docs/README.md (lines 9-10)
These are local build instructions, so they don't strictly contradict the new guidance, but it might be worth rewording step 2 (or pointing to the release guide) so nobody preparing a release adds the selector entry too early again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workingCI/CDCI/CD infrastructurecuda.bindingsEverything related to the cuda.bindings modulecuda.coreEverything related to the cuda.core modulecuda.pathfinderEverything related to the cuda.pathfinder moduledocumentationImprovements or additions to documentation
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
— codex GPT-6 on behalf of Ralf —
Description
Adding numeric release notes for an upcoming release forced a public version-selector entry before its documentation existed. Core 1.4.0 consequently appeared in the live dropdown with a destination that returned 404.
Remove the selector requirement and its obsolete tests from the staged release-note hook, keeping bindings/metapackage note pairing intact. Remove the premature Core 1.4.0 selector entry while retaining its release notes. The always-run hook now exercises this real case in both native pre-commit CI jobs.
Correct the Core and bindings release guides, all five package documentation READMEs, and CI documentation: local builds need no selector entry; add release entries on
mainafter the component is published and its versioned documentation is deployed. Main deployments own the shared selectors; a missing entry can be repaired there without changing a release tag.Inspected
cuda_bindings_12/docs/build_docs.shandcuda_bindings_13/docs/build_docs.sh: CUDA 12 consumes CUDA 13's canonical selector, so no root-specific build changes are needed. No SYNCED blocks are touched.Validation:
pre-commit run --all-filespasses, including the staged-note hook with Core 1.4.0's selector entry removed.pre-commit run --all-files, including authored-link checks. Full CUDA CI is intentionally deferred for that follow-up; automatic direct PR checks may run.The
[doc-only]title directive retains CI-tool tests, pre-commit checks, Linux builds, and documentation validation while skipping package runtime tests. These changes affect release-note tooling, selector metadata, and release guidance.Checklist